Skip to content

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Aug 25, 2025

Issue

Setting read-only-uri before username generation will trigger a database created event in the client before the database is actually created

Solution

Only set the uri if credentials are set

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.27%. Comparing base (655b251) to head (db8529b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/relations/postgresql_provider.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   73.29%   73.27%   -0.02%     
==========================================
  Files          15       15              
  Lines        3921     3922       +1     
  Branches      574      575       +1     
==========================================
  Hits         2874     2874              
- Misses        833      834       +1     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp added the bug Something isn't working as expected label Aug 25, 2025
@dragomirp dragomirp requested review from a team, taurus-forever and marceloneppel and removed request for a team August 26, 2025 09:14
@dragomirp dragomirp marked this pull request as ready for review August 26, 2025 10:34
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can PG14 have a chance to have username without password and vice versa?

@dragomirp dragomirp merged commit 07b23e6 into main Aug 26, 2025
1206 of 1273 checks passed
@dragomirp dragomirp deleted the early-db-created branch August 26, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants