fix: v1 CI is now on main #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Mar 26, 2025
| @@ -9,5 +9,5 @@ on: | |||
| jobs: | |||
| pull-request: | |||
| name: PR | |||
| uses: canonical/observability/.github/workflows/charm-pull-request.yaml@feature/v1 | |||
| uses: canonical/observability/.github/workflows/charm-pull-request.yaml@main | |||
There was a problem hiding this comment.
Shall we use the tags rather than branch name?
https://github.com/canonical/observability/tags
There was a problem hiding this comment.
There might still be a bit of a misunderstanding then, I think. The v1 tag points at a commit from 2 weeks ago from before all the TIOBE changes @michaeldmitry and @simskij did. Is main our, yet unreleased, v2 then? Or do we miss a step in merging?
For the tester, we likely want to be using main anyway as this is for testing the edge CI IMO. But I might be wrong :)
cc @lucabello
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.