Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pin Python dependencies #25

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat: Pin Python dependencies #25

merged 4 commits into from
Sep 19, 2023

Conversation

phoevos
Copy link
Contributor

@phoevos phoevos commented Sep 12, 2023

  • Move notebook dependencies to requirements.in files
  • Compile dependencies into requirements.txt files using the root-level tox update-requirements action
  • Install dependencies from the corresponding requirements.txt before running each notebook

Closes #24

@phoevos phoevos requested a review from a team September 12, 2023 16:14
DnPlas
DnPlas reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phoevos, tiny little comments.

tests/notebooks/e2e-wine/requirements.in Show resolved Hide resolved
tests/notebooks/katib/katib-integration.ipynb Show resolved Hide resolved
tests/utils.py Show resolved Hide resolved
DnPlas
DnPlas reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved all conversations except for this one. A quick simple comment would resolve this. Thanks @phoevos, other than that LGTM.

@phoevos phoevos force-pushed the kf-4339-pin-dependencies branch from 3005f22 to cc7a54b Compare September 18, 2023 09:22
DnPlas
DnPlas approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thanks @phoevos

@phoevos phoevos merged commit c376579 into main Sep 19, 2023
@phoevos phoevos deleted the kf-4339-pin-dependencies branch September 19, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin notebook dependencies
2 participants
@phoevos @DnPlas