Skip to content

remove json.stringify which causes errors #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove json.stringify which causes errors #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a81ae18
remove json.stringify which causes errors
green3g Jun 20, 2017
984f092
use canjs 3 libs
green3g Jun 20, 2017
7cd4b80
Remove canjs 2.x dependency
green3g Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
const getIntermediateAndImports = require('./intermediate_and_imports');
// const getIntermediateAndImports = require('can-stache/src/intermediate_and_imports');
// const getIntermediateAndImports = require('can/dist/cjs/view/stache/intermediate_and_imports');
const getIntermediateAndImports = require("can-stache/src/intermediate_and_imports");


const getTemplate = (source, imports) => {
const requires = imports.map(i => `require('${i}');`).join('\n');

return `var stache = require('can/dist/cjs/view/stache/stache');
var mustacheCore = require('can/dist/cjs/view/stache/mustache_core');
var getIntermediateAndImports = require('can/dist/cjs/view/stache/intermediate_and_imports');
return `var stache = require('can-stache');
var mustacheCore = require('can-stache/src/mustache_core');
var getIntermediateAndImports = require("can-stache/src/intermediate_and_imports");

${requires}

Expand All @@ -20,19 +18,18 @@ var renderer = stache(intermediate);

module.exports = function (scope, options, nodeList) {
var moduleOptions = { module: module };

if (!(options instanceof mustacheCore.Options)) {
options = new mustacheCore.Options(options || {});
}

return renderer(scope, options.add(moduleOptions), nodeList);
};`;
}

module.exports = function canStacheLoader(source) {
const src = JSON.stringify(source);

const intermediateAndImports = getIntermediateAndImports(source);
const intermediateAndImports = getIntermediateAndImports(source);

return getTemplate(src, intermediateAndImports.imports);
return getTemplate(source, intermediateAndImports.imports);
};
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"mustache"
],
"dependencies": {
"can": "^2.3.31",
"can-stache": "^3.0.25",
"can-view-parser": "^3.3.0"
},
Expand Down