Skip to content

Commit

Permalink
Line comments are not posted in create_review() (PyGithub#909)
Browse files Browse the repository at this point in the history
When create_review() is called with comments in the comments argument,
they are not actually posted in the API call.
  • Loading branch information
brianjmurrell authored and sfdye committed Sep 26, 2018
1 parent 598bee8 commit a18eeb3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions github/PullRequest.py
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,8 @@ def create_review(self, commit, body, event=github.GithubObject.NotSet, comments
post_parameters['event'] = 'COMMENT' if event == github.GithubObject.NotSet else event
if comments is github.GithubObject.NotSet:
post_parameters['comments'] = []
else:
post_parameters['comments'] = comments
headers, data = self._requester.requestJsonAndCheck(
"POST",
self.url + "/reviews",
Expand Down

0 comments on commit a18eeb3

Please sign in to comment.