Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update requirements and build system #555

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Conversation

jsstevenson
Copy link
Member

No description provided.

@jsstevenson jsstevenson added the priority:low Low priority label Jul 12, 2024
@jsstevenson jsstevenson marked this pull request as ready for review July 15, 2024 15:56
@jsstevenson jsstevenson requested a review from korikuzma July 15, 2024 15:56
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick one while I finish reviewing the other changes

from importlib.metadata import PackageNotFoundError, version

try:
__version__ = version("{{ cookiecutter.project_slug }}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = version("{{ cookiecutter.project_slug }}")
__version__ = version("variation-normalizer")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just noticed this agh

@jsstevenson jsstevenson merged commit 9f7e149 into staging Jul 15, 2024
9 checks passed
@jsstevenson jsstevenson deleted the build-stuff branch July 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants