fix(build): add disease-normalizer as required dep #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
added
build
jsstevenson
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
I'm wondering if we should consider updating cicd tests to install minimal deps needed to help prevent bugs like this in the future
yeah couldn't hurt! Realistically the etl and the app itself are kind of separate things with their own dependencies, so ideally we'd be testing them separately, rather than handling them all under a test suite that depends on the etl dependency group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add this in #449 🤦♀️ Disease normalizer is now required since we use its schemas in the QueryHandler
I'm wondering if we should consider updating cicd tests to install minimal deps needed to help prevent bugs like this in the future