[FIX] Enable session_redis to work with Sentry #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the sentry module is loaded, it overrides odoo.http.Application with a middleware object that wraps the original, but does not proxy it. Thus the session_store property that session_redis monkeypatches is no longer there. This fix intends to avoid that, without having very specific knowledge about the sentry module baked in. The solution seems to work, but has the risk that if the Application class is fully replaced (i.e. if it is not even wrapped), then this new method may lead to this module simply not working, and the reasons for it may be difficult to debug. But the only way around that would be to explicitly check the wrapper object contains the expected class, and that is basically the same as depending on the sentry module.
|
@vrenaville who would review this? for support with OCA/server-tools#3174 |
|
this does not seem to actually work. so WIP. it works for some time then started to write to the file store session. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: avoinsystems@a09a813
When the sentry module is loaded, it overrides odoo.http.Application with a middleware object that wraps the original, but does not proxy it. Thus the session_store property that session_redis monkeypatches is no longer there.
This fix intends to avoid that, without having very specific knowledge about the sentry module baked in.
The solution seems to work, but has the risk that if the Application class is fully replaced (i.e. if it is not even wrapped), then this new method may lead to this module simply not working, and the reasons for it may be difficult to debug. But the only way around that would be to explicitly check the wrapper object contains the expected class, and that is basically the same as depending on the sentry module.