Skip to content

[MIG] attachment_s3: Migration to 16.0 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

jjscarafia
Copy link

No description provided.

@jjscarafia jjscarafia force-pushed the 16.0-t-attachment-s3-maq branch 2 times, most recently from ca15334 to de688ac Compare December 24, 2022 19:45
@sbidoul
Copy link
Contributor

sbidoul commented Feb 22, 2023

Hi @jjscarafia. Would you mind merging this commit into this PR which adds the setup directory?

@adrienpeiffer
Copy link

Hi @jjscarafia Thanks for that. I prefer this way and it works perfectly

@gurneyalex @vrenaville Do you think it is possible to merge this ? We can continue after to improve the management of the stream

@vrenaville
Copy link
Member

@jjscarafia @adrienpeiffer
I will merge it, I just need to figure out what's the issue with pylint travis error

@sbidoul
Copy link
Contributor

sbidoul commented Mar 1, 2023

@vrenaville please don't forget to pick up adhoc-dev#1

@sbidoul
Copy link
Contributor

sbidoul commented Mar 13, 2023

Hi @vrenaville. Any news here?

Note it should be reasonably easy to apply the oca addons repo template here. It should now have everything needed to be configured for any organization.

@vrenaville
Copy link
Member

@adrienpeiffer

Could you please rebase, I have add your proposition in base_attachment, it's much more standard #427

We have spend time to switch to github actions, so rebase will fix your build

@jjscarafia jjscarafia force-pushed the 16.0-t-attachment-s3-maq branch from de688ac to 4a2c919 Compare June 7, 2023 15:36
@jjscarafia
Copy link
Author

@vrenaville rebase done!
thanks

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.05%. Comparing base (0d0ca60) to head (4a2c919).
Report is 9 commits behind head on 16.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             16.0     #401   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files          33       33           
  Lines         760      760           
  Branches      106      106           
=======================================
  Hits          274      274           
  Misses        480      480           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@Firepoison
Copy link

Is there any reason this wasn't committed to 16 yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants