-
Notifications
You must be signed in to change notification settings - Fork 226
[MIG] attachment_s3: Migration to 16.0 #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
ca15334
to
de688ac
Compare
Hi @jjscarafia. Would you mind merging this commit into this PR which adds the setup directory? |
Hi @jjscarafia Thanks for that. I prefer this way and it works perfectly @gurneyalex @vrenaville Do you think it is possible to merge this ? We can continue after to improve the management of the stream |
@jjscarafia @adrienpeiffer |
@vrenaville please don't forget to pick up adhoc-dev#1 |
Hi @vrenaville. Any news here? Note it should be reasonably easy to apply the oca addons repo template here. It should now have everything needed to be configured for any organization. |
Could you please rebase, I have add your proposition in base_attachment, it's much more standard #427 We have spend time to switch to github actions, so rebase will fix your build |
de688ac
to
4a2c919
Compare
@vrenaville rebase done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #401 +/- ##
=======================================
Coverage 36.05% 36.05%
=======================================
Files 33 33
Lines 760 760
Branches 106 106
=======================================
Hits 274 274
Misses 480 480
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Is there any reason this wasn't committed to 16 yet? |
No description provided.