Skip to content

feat: integrate Langfuse #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat: integrate Langfuse #2467

wants to merge 24 commits into from

Conversation

fengju0213
Copy link
Collaborator

@fengju0213 fengju0213 commented May 23, 2025

Description

fixed:#2245

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have an instruction on how to self-host langfuse for observability? Also the current implementation does not abstract the same way as AgentOps. Is is possible to abstract them in the same way?

@fengju0213
Copy link
Collaborator Author

fengju0213 commented May 26, 2025

Can we have an instruction on how to self-host langfuse for observability? Also the current implementation does not abstract the same way as AgentOps. Is is possible to abstract them in the same way?

If necessary, we could add a self-hosted mode. However, essentially, this would just involve running Langfuse inside Docker. Should we add a parameter to let users launch Langfuse with a one-click Docker build, or leave it to them to start the service manually
According to Langfuse's documentation, the current approach would be more convenient.

Comment on lines +33 to +34
public_key: Langfuse public key. Can be set via LANGFUSE_PUBLIC_KEY.
secret_key: Langfuse secret key. Can be set via LANGFUSE_SECRET_KEY.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public_key: Langfuse public key. Can be set via LANGFUSE_PUBLIC_KEY.
secret_key: Langfuse secret key. Can be set via LANGFUSE_SECRET_KEY.
public_key (Optional[str]): Langfuse public key. Can be set via
LANGFUSE_PUBLIC_KEY environment variable.
(default: None)

@lightaime
Copy link
Member

Can we have an instruction on how to self-host langfuse for observability? Also the current implementation does not abstract the same way as AgentOps. Is is possible to abstract them in the same way?

If necessary, we could add a self-hosted mode. However, essentially, this would just involve running Langfuse inside Docker. Should we add a parameter to let users launch Langfuse with a one-click Docker build, or leave it to them to start the service manually According to Langfuse's documentation, the current approach would be more convenient.

  1. we can show how to setup langfuse locally with a README
  2. I think we need to abstract the observability tools into a unified interfece. Otherwise, it would be difficult to maintain. @Wendong-Fan what do you think?

@Wendong-Fan Wendong-Fan added this to the Sprint 30 milestone Jun 1, 2025
@Wendong-Fan
Copy link
Member

pending to wait for #2536 finish

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fengju0213!

Regarding the observability feature, after reviewing several existing solutions, I believe it would be more beneficial for us to develop a foundational observability tool in-house rather than integrating various third-party solutions. Here's why:

  • Unified Solution: We only need a single, cohesive observability solution to monitor our system's operations.
  • Native Integration & Better Compatibility: As a framework, building this feature ourselves from the ground up will allow for more native integration. This approach will ensure the tool is better suited to track data generated by our own framework.
  • OpenTelemetry Compatibility: Some third-party solutions like Langfuse support OpenTelemetry, we can also leverage OpenTelemetry-compatible libraries (e.g., OpenLIT, OpenLLMetry, Arize, MLflow). By building our own native support, users who prefer other OpenTelemetry-based tools (like Langfuse) could still integrate with and monitor our system effectively.

For the next steps, I propose the following:

  • Define Key Performance Indicators (KPIs): We need to identify and define the critical KPIs for tracking agent performance. This will involve studying existing solutions to compile a comprehensive list of metrics for our observability system.

  • Select an OpenTelemetry-based Framework: Choose the most suitable framework that aligns with OpenTelemetry standards to build upon. Some libraries we could check:
    OpenLIT
    OpenLLMetry
    Arize
    MLflow

  • Develop the Tracking System: Construct the system to monitor and track agent operations based on the defined KPIs and selected framework

cc @lightaime

@lightaime
Copy link
Member

Thanks @Wendong-Fan.

Just to understand why we want observability tool in-house at the moment: what kinds of problem that exisiting observability tools cannot solve? Developing an observability tool in-house could be a pretty big project, not quite sure if that is the priority at the moment.

Copy link

coderabbitai bot commented Jun 4, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants