Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roi rectangle adapt to retina display #2059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YoloMao
Copy link

@YoloMao YoloMao commented Mar 31, 2025

Description

this pr in order to drawing the correct roi on retina display.

Before:
www_google_com_0331185148
After:
www_google_com_0331185031

Checklist

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

@X-TRON404 X-TRON404 self-requested a review March 31, 2025 14:10
@YoloMao YoloMao force-pushed the fix/browser_toolkit_devicePixelRatio branch from 889a241 to 9fd14f7 Compare April 2, 2025 09:37
@fengju0213
Copy link
Collaborator

@YoloMao thanks !did you encounter the issue while using the Mac system?

@YoloMao
Copy link
Author

YoloMao commented Apr 9, 2025

@YoloMao thanks !did you encounter the issue while using the Mac system?

This bug occurs on my macbook pro's Built-in Display, and on my Extended Display everything is fine.

@fengju0213
Copy link
Collaborator

@YoloMao thanks !did you encounter the issue while using the Mac system?

This bug occurs on my macbook pro's Built-in Display, and on my Extended Display everything is fine.

@YoloMao i see, I'll try to reproduce it on my Mac first today and get back to you later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants