BaseVectorStorage-Add-Search-Function #2058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the search test
Add the search function test
Add the search function test
2 tasks
subway-jack
changed the title
zjrwtx
reviewed
Mar 31, 2025
| ) | ||
|
|
||
| schema.add_field( | ||
| field_name="id", | ||
| datatype=DataType.VARCHAR, | ||
| descrition='A unique identifier for the vector', | ||
| descrition="A unique identifier for the vector", |
There was a problem hiding this comment.
Suggested change
| descrition="A unique identifier for the vector", | |
| description="A unique identifier for the vector", |
|
please run pre-commit before commit |
zjrwtx
reviewed
Mar 31, 2025
| id: str, | ||
| payload: Dict[str, Any], | ||
| ) -> "VectorDBSearchResult": | ||
| r"""A class method to construct a `VectorDBSearchResult` instance.""" |
There was a problem hiding this comment.
docstring may need may clear
There was a problem hiding this comment.
Thanks, I'll add more details
| id: str, | ||
| payload: Dict[str, Any], | ||
| ) -> "VectorDBSearchResult": | ||
| r"""A class method to construct a `VectorDBSearchResult` instance.""" |
There was a problem hiding this comment.
docstring may need more clear
There was a problem hiding this comment.
Thanks, I'll add more details
|
Thanks @subway-jack for the contributions! @AveryYay Hi Avery. It would be great if you can help with reviewing this PR. |
add the more description detail
add the more description detail
add the more description detail
add the more description detail
fix the E501
Sure! |
AveryYay
reviewed
Apr 4, 2025
| if isinstance(cond, dict): | ||
| expressions = [] | ||
| for op, v in cond.items(): | ||
| if op == "$eq": |
There was a problem hiding this comment.
I would consider using a dictionary to do the if-else matching here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!