Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Agentic Search Cookbook #2053

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: Added Agentic Search Cookbook #2053

wants to merge 7 commits into from

Conversation

JoyceXu02
Copy link
Collaborator

Description

Added agent search cookbook to the docs

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

Fix #1686

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@JoyceXu02 JoyceXu02 requested a review from Wendong-Fan March 30, 2025 15:01
Wendong-Fan
Wendong-Fan reviewed Mar 30, 2025
View reviewed changes
docs/cookbooks/advanced_features/agent_search.ipynb
@@ -0,0 +1,592 @@
{
Copy link
Member

@Wendong-Fan Wendong-Fan Mar 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this link is not public, please update the access


Reply via ReviewNB

docs/cookbooks/advanced_features/agent_search.ipynb
@@ -0,0 +1,592 @@
{
Copy link
Member

@Wendong-Fan Wendong-Fan Mar 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Line #4.        model_platform=ModelPlatformType.DEFAULT,

for the model_platform and model_type, better set up open ai instead of DEFAULT?


Reply via ReviewNB

docs/cookbooks/advanced_features/agent_search.ipynb
@@ -0,0 +1,592 @@
{
Copy link
Member

@Wendong-Fan Wendong-Fan Mar 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Line #18.        tools=[FunctionTool(SearchToolkit().search_google)],

use search_duckduckgo instead of search_google,so that user don't need to config google api key?


Reply via ReviewNB

Copy link
Collaborator

@zjrwtx zjrwtx Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make some comment like chose search_duckduckgo (no need apikey ),chose search_google,the apikey link:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make some comment like chose search_duckduckgo (no need apikey ),chose search_google,the apikey link:

Thanks @zjrwtx, I can add some comments on that

docs/cookbooks/advanced_features/agent_search.ipynb
@@ -0,0 +1,592 @@
{
Copy link
Member

@Wendong-Fan Wendong-Fan Mar 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use RolePlaying with critic to better show this use case?


Reply via ReviewNB

@Wendong-Fan
Copy link
Member

thanks @JoyceXu02 , left some comments above

@JoyceXu02
Copy link
Collaborator Author

JoyceXu02 commented Mar 31, 2025 •
edited
Loading

thanks @JoyceXu02 , left some comments above

Thanks @Wendong-Fan, I added roleplay to the original implementation in the cookbook.

zjrwtx
zjrwtx reviewed Mar 31, 2025
View reviewed changes
docs/cookbooks/advanced_features/agent_search.ipynb
@@ -0,0 +1,651 @@
{
Copy link
Collaborator

@zjrwtx zjrwtx Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update the package version?


Reply via ReviewNB

@JoyceXu02 JoyceXu02 requested review from Wendong-Fan and zjrwtx April 4, 2025 15:45
zjrwtx
zjrwtx reviewed Apr 12, 2025
View reviewed changes
docs/cookbooks/advanced_features/agent_search.ipynb
@@ -0,0 +1,676 @@
{
Copy link
Collaborator

@zjrwtx zjrwtx Apr 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add critic and ropleplaying comment here?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zjrwtx, I have added critic and roleplaying comments at the beginning.

@zjrwtx
Copy link
Collaborator

zjrwtx commented Apr 13, 2025

thanks @JoyceXu02 ,LGTM.what do you thinks @Wendong-Fan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjrwtx zjrwtx zjrwtx left review comments

@Wendong-Fan Wendong-Fan Awaiting requested review from Wendong-Fan

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Agentic search cookbook
3 participants
@JoyceXu02 @Wendong-Fan @zjrwtx