fix: allow Menu to reopen when hide animation callback never fires

[ErfanBagheri404]

Fixes #4763

On React Native >= 0.80 the hide animation completion callback is not delivered, so prevRendered.current stayed true and the menu could never be shown again after being dismissed.

Reset prevRendered.current before starting the hide animation instead of in its completion callback.

[MikitasK]

I suppose, moving prevRendered.current = false before hide animation can introduce a race. if the menu closes while its opening animation is running, the interrupted opening callback can set this back to true, preventing the menu from reopening

could we handle interrupted opening & hiding animations using finished and add a test for quickly closing & reopening the menu?

}).start(({ finished }) => {
  if (!finished) {
    return;
  }
  setMenuLayout({ width: 0, height: 0 });
  setRendered(false);
  prevRendered.current = false;
  focusFirstDOMNode(anchorRef.current);
});

[MikitasK]

Thanks @ErfanBagheri404 🙏
LGTM 👌
just one non-blocking suggestion: regression test covering close & reopen behavior would be helpful

[satya164]

according to this comment #4763 (comment) - the issue happens in react native 0.79

but the pr says React Native >= 0.80. can you verify that you're fixing the same issue?

also please provide before/after videos.

[satya164]

resetting prevRendered.current but leaving everything else like rendered state and focus restoration doesn't make sense and leaves the menu in a broken state if the callback is never delivered.

though the callback not firing sounds like a big regression in react native so a lot of other things should be broken

[ErfanBagheri404]

On the version question: the reports in the thread are consistent about the boundary. bjeld hit it after upgrading to RN 0.80 with paper 5.14.5 and downgrading to 0.79.4 fixed it, atheck and adamgajzlerowicz both on 0.80.1, raiyanihiren on 0.81. Nobody reported it below 0.80, so "React Native >= 0.80" matches what users are seeing.

The PR is rebased onto the current main now that the Menu component was rewritten to Reanimated. In that rewrite the reopen deadlock is gone, but the broken state you described is still there and is what this fixes now: when the hide callback is not delivered, setRendered(false) never ran, so the portal stayed mounted after close and focusFirstDOMNode(anchorRef.current) never returned focus to the anchor. hide() now resets the portal and focus synchronously, cancels any in-flight show animation so a late finished callback cannot mark a hidden menu as shown, and the completion callback only zeroes menuLayout when the menu was not reopened meanwhile.

I can't record before/after videos myself, no RN setup here to film one. The close-reopen regression test in the PR covers the visible behavior; if a video is still a hard requirement for merging, someone with a 0.80 device would need to record it.