-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Update react-native to 0.82 #4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| }, | ||
| "dependencies": { | ||
| "@callstack/react-theme-provider": "^3.0.9", | ||
| "@react-native/babel-preset": "^0.82.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be at most devDependency and never a dependency - this will get installed with the paper itself in the projects and the projects have their own babel config.
but...
I would avoid the preset altogether since every project will use that preset with it's own babel config. In theory, running the preset in the lib should reduce the transpilation time of the library in the projects, but every file still is going to be parsed by babel and then (most likely, needs verifying) transformations will try to run again but will result in noop since it was already transformed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc it's needed for tests etc.
the lib isn't actually compiled with this since bob has an internal Babel config unless overridden. the main benefit of precompiling is to make it seamlessly work with anything other than metro (jest, vite, webpack) since they don't compile node_modules by default.
| "husky": "^1.3.1", | ||
| "jest": "^29.6.3", | ||
| "jest-file-snapshot": "^0.3.2", | ||
| "metro-react-native-babel-preset": "0.73.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed since this is deprecated nowadays
| @@ -1,4 +1,4 @@ | |||
| import React from 'react'; | |||
| import React, { JSX } from 'react'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be needed to import this, probably a configuration issue somewhere
| @@ -1,4 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import { JSX } from 'react'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be needed to import this, probably a configuration issue somewhere
| @@ -1,4 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import { JSX } from 'react'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be needed to import this, probably a configuration issue somewhere
Updates the react-native version to 0.82 and Example app expo to 54.
There were several updates to unit tests and typescript.
Motivation
Just to keep everything updated
Test plan