feat: add overlayAccessibilityLabel prop to Dialog - #3915
Open
jeferson-sb wants to merge 2 commits into
Open
Conversation
|
Hey @jeferson-sb, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
May 8, 2025 09:47
1062366 to
1da5d15
Compare
MikitasK
reviewed
Aug 11, 2026
MikitasK
left a comment
MikitasK
left a comment
There was a problem hiding this comment.
LGTM 👌
could you just add a regression test in Dialog.test.tsx confirming that overlayAccessibilityLabel is applied to the backdrop? this will help prevent future regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward
overlayAccessibilityLabelon Dialog component to be able to change the accessible label on the modal.Addresses #3911
Test plan