Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore resizeMode logic after New Arch update #138

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

retyui
Copy link
Collaborator

@retyui retyui commented Feb 19, 2024

Summary

After migration to the New Arch iOS resizeMode was affected and doesn't work properly

Test plan

example of resizeMode: 'stretch'

Before (doesn't work) After (fixed)

@retyui retyui requested a review from mateusz1913 February 19, 2024 17:47
ios/RNCImageEditor.mm Outdated Show resolved Hide resolved
ios/RNCImageEditor.mm Outdated Show resolved Hide resolved
@retyui retyui force-pushed the fix/retyui/resizeMode-logic branch from fffa207 to 3a93a25 Compare February 20, 2024 18:01
@retyui retyui requested a review from mateusz1913 February 20, 2024 18:07
@retyui retyui force-pushed the fix/retyui/resizeMode-logic branch from 01bed3d to d9c6687 Compare February 22, 2024 12:58
Copy link
Member

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥳

@retyui retyui merged commit c59e226 into master Feb 22, 2024
6 checks passed
@retyui retyui deleted the fix/retyui/resizeMode-logic branch February 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants