-
Notifications
You must be signed in to change notification settings - Fork 31
docs(getting-started): revamp guides with CLI-first approach #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 2. Drag these files into your native iOS app's Xcode project: | ||
| - **`hermesvm.xcframework`** - JavaScript runtime | ||
| - **`ReactBrownfield.xcframework`** - React Native Brownfield library | ||
| - **`<framework_target_name>.xcframework`** - Your framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to hint users into Brownie here?
thymikee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly good! Missing Expo instructions, and (possibly separately) based on that we should also update the README. Left a few improvements, mostly around the commands, because AFAIK we should use npx brownfield as a shorthand
- Split quick-start into platform-specific iOS and Android guides - Add detailed step-by-step instructions for XCFramework and AAR packaging - Explain brownfield CLI purpose and benefits - Add Xcode/Android Studio screenshots from Rock docs - Remove Rock references, focus on built-in CLI - Add bold highlights for key terms and commands
ee2fc17 to
5ce0513
Compare
Summary
Changes
quick-start.mdx- Simplified to installation + CLI explanation with benefitsios.mdx(new) - Detailed 8-step guide for XCFramework packaging and integrationandroid.mdx(new) - Detailed 10-step guide for AAR packaging and integration_meta.json- Updated navigation orderexamples.mdx- Fixed typopublic/images/- Added 6 screenshots from Rock docsMotivation
Previous docs had multiple paths (CLI, Rock, custom scripts) which was confusing. This PR consolidates around the built-in CLI for a clearer onboarding experience.
All of the integration guides were taken from Rock JS docs. Shoutout to @thymikee for creating them. (https://www.rockjs.dev/docs/brownfield/ios)