-
Notifications
You must be signed in to change notification settings - Fork 30
feat: rework monorepo with Turborepo; update example apps and CI pipelines #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
okwasniewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Overall looks really good, left few minor comments
d58773e to
d5c11f5
Compare
|
Hi @hurali97 @thymikee @okwasniewski, the PR is ready for review. The CLI part has been decoupled and will be addressed in a separate PR. |
Co-authored-by: Oskar Kwaśniewski <[email protected]>
thymikee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
Summary
This PR:
CONTRIBUTING.mddescribing the scripts & anexamples.mdxpage for docs to list and briefly describe each of the example apps in the demo to enhance DX.turbodirectories) and Android build & Gradle cachesgradle/wrapper-validation-actionto the superceding action:gradle/actions/wrapper-validationThe changes address mainly demo apps and CI used to test building a native application using in-source RN app, which firstly did not produce a standalone packaged RN lib artifact and secondly didn't provide the opportunity for testing the CLI. The new setup adds 3 more apps: RN app, iOS consumer app & Android consumer app. The new CI builds the integrated tester app.
Test plan
CI green + all 3 apps working - tested manually.