Skip to content

Conversation

hurali97
Copy link
Member

@hurali97 hurali97 commented Sep 5, 2025

Summary

This fixes the cyclic dependency caused by when copying the generated SO files. This happened because we were doing it as part of preBuild task of the AAR library. With a recent change in react-native, where they now wait for preBuild task for each subProject to be evaluated first and then run the app:preBuild task.

We now move our copy task for SO files to mergeJniLibsTask which executes after the preBuild.

Apart from it and not related to cyclic dependency issue, we also move the app:createBundleReleaseJsAndAssets to preReleaseBuild task.

Test plan

Tested locally on a project on RN>0.81 and RN<0.81 - 🟢

@thymikee
Copy link
Member

thymikee commented Sep 8, 2025

Tests are passing, so I think we're good. @hurali97 any extra case you'd like to handle in the testing to make sure this is robust?

@hurali97
Copy link
Member Author

hurali97 commented Sep 8, 2025

Tests are passing, so I think we're good. @hurali97 any extra case you'd like to handle in the testing to make sure this is robust?

We are good, since #128 is now merged, I would like to rebase to include those changes as well in the scope of this PR. Should be ready today 👍

@hurali97 hurali97 force-pushed the fix/cyclic-task-dep branch from dabf669 to 43e4d15 Compare September 8, 2025 14:35
@hurali97 hurali97 marked this pull request as ready for review September 8, 2025 14:35
@thymikee thymikee changed the base branch from main to mosoakinyemi-readme-patch-1 September 8, 2025 14:59
@thymikee thymikee changed the base branch from mosoakinyemi-readme-patch-1 to main September 8, 2025 14:59
@thymikee thymikee merged commit 54c2d2a into main Sep 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants