You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
restore progressive disclosure: reduce the three always/high-frequency guidance files from 120,315 to 27,868 bytes while preserving repository-specific traps and routing situational detail to focused owners
make CONTEXT.md a domain glossary again, move selector-capture reliability into its own guide, and remove two unreferenced historical reports from the live context surface
add a registered, docs-triggered agent-guidance gate that enforces context budgets, glossary shape, and valid routing links
address adversarial review by restoring the Interactor glossary term, trimming derivable hard rules, removing the duplicate testing budget, and installing workspace dependencies in the guidance CI job
Why this is a root-cause change
The contributor context mixed durable vocabulary, implementation detail, testing policy, historical reports, and generic engineering advice in files loaded for nearly every task. That made the exceptional path easier to encounter than the owning interfaces and source-of-truth registries. This change repairs the information architecture and makes renewed accretion fail CI; it does not add another prose reminder or behavior fallback.
Surviving next-major legacy cleanup remains owned by #1370. The three local uniqueStrings copies found during review are tracked separately in #1890, including a request for mechanical enforcement rather than another reminder.
Adversarial evidence
pre-cleanup guidance contract: red on oversized AGENTS.md and non-glossary CONTEXT.md
planted workflow ownership break: gate manifest reported the unowned agent-guidance gate and missing docs-triggered lane
planted production message sniff: the Maestro regression failed when identical error text was accepted without details.reason; restored typed-only classification passes 2/2
the first guidance workflow run failed because its dependency installation was explicitly disabled; the review fix removes that override so the canonical pnpm gate has its workspace packages
Validation
pre-review pnpm check:affected --run — passed immediately before its push
affected coverage rerun encountered unrelated timeout-shaped failures in unchanged Apple/provider tests; the original runner-client failure passed alone in 155 ms, and the review fix was pushed for authoritative GitHub CI at the maintainer's direction
package verification, layering, fallow, gate manifest, Maestro conformance, and agent-guidance contract passed in local validation
No live-device validation: this PR changes contributor guidance, gate wiring, and regression specificity; production interaction behavior remains the merged #1886 implementation.
The new Agent Guidance workflow cannot run its own gate: it passes install-deps: 'false', but pnpm gate agent-guidance loads scripts/node-test-tmpdir.ts → src/utils/exec.ts → @agent-device/kernel. The exact-head job therefore fails with ERR_MODULE_NOT_FOUND before executing the guidance contracts. Please install dependencies for this job (or refactor the gate to be genuinely dependency-free) and rerun; this is a deterministic workflow configuration failure, not an infrastructure flake.
Focused guidance, gate-manifest, formatting, and diff checks pass. The PR body now records the local broad-run timeout evidence and the CI handoff accurately.
Re-reviewed at 95a9be3: the Agent Guidance dependency blocker is fixed and its exact-head check is green. I found no remaining code issues. The iOS Smoke failure is unrelated to this PR: the untouched testBareTypeUsesTappedInputWhenSoftwareKeyboardIsHidden runner test entered only “h” instead of “hardware-keyboard” (the same assertion then failed twice), while this PR changes no executable iOS code and the lane passed at the preceding head. Please rerun iOS Smoke; the code is clean, but the PR is not merge-ready until that exact-head check is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTEXT.mda domain glossary again, move selector-capture reliability into its own guide, and remove two unreferenced historical reports from the live context surfaceagent-guidancegate that enforces context budgets, glossary shape, and valid routing linksInteractorglossary term, trimming derivable hard rules, removing the duplicate testing budget, and installing workspace dependencies in the guidance CI jobWhy this is a root-cause change
The contributor context mixed durable vocabulary, implementation detail, testing policy, historical reports, and generic engineering advice in files loaded for nearly every task. That made the exceptional path easier to encounter than the owning interfaces and source-of-truth registries. This change repairs the information architecture and makes renewed accretion fail CI; it does not add another prose reminder or behavior fallback.
Surviving next-major legacy cleanup remains owned by #1370. The three local
uniqueStringscopies found during review are tracked separately in #1890, including a request for mechanical enforcement rather than another reminder.Adversarial evidence
AGENTS.mdand non-glossaryCONTEXT.mdagent-guidancegate and missing docs-triggered lanedetails.reason; restored typed-only classification passes 2/2pnpm gatehas its workspace packagesValidation
pnpm check:affected --run— passed immediately before its pushpnpm check:agent-guidance,pnpm check:gate-manifest,pnpm format:check, andgit diff --check— passedrunner-clientfailure passed alone in 155 ms, and the review fix was pushed for authoritative GitHub CI at the maintainer's directionNo live-device validation: this PR changes contributor guidance, gate wiring, and regression specificity; production interaction behavior remains the merged #1886 implementation.