Skip to content

Two small features added #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Two small features added #9

wants to merge 5 commits into from

Conversation

sebiik
Copy link

@sebiik sebiik commented Dec 15, 2019

Hi Caleb, thank you for your package, I use it frequently. I'm simply using a pull request here just to send you this message, so no worries if you don't merge or even look at my changes.

As to the changes I made:

  1. I've added a safety exit when you try to apply a macro while still in recording mode. It will simply not apply anything and take you out of recording mode first (as I feel that once you forget to leave recording mode your macro is unusable anyway and you'll have to start over).

  2. I've felt that an append function would be neat. There are two versions as I felt some people will want a pure append mode like in Vim (Q), but that may become confusing because it lets you add your moves with no regard to what the current macro does. So I've added 'apply then append' mode (g @) which may be more intuitive for some as you can run your macro, see what it did, then add your changes from there.

I'm not a pro coder so if you feel that I wrote some bad code or messed up yours I apologize in advance!

Thank you again for this package,
Seb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant