Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup — remove HeadSeo from migrated app router components #18576

Merged
merged 1 commit into from
Jan 10, 2025
Merged

chore: cleanup — remove HeadSeo from migrated app router components #18576

merged 1 commit into from
Jan 10, 2025
+40 −12

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 10, 2025 •
edited
Loading

What does this PR do?

  • HeadSeo is not needed in app router as metadata is handled by generateMetadata (built-in metadata api)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 10, 2025 7:17am
calcom-web-canary ⬜️ Ignored (Inspect) Jan 10, 2025 7:17am

@graphite-app graphite-app bot requested a review from a team January 10, 2025 07:17
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 10, 2025
@hbjORbj hbjORbj changed the title chore: remove headseo from app router components chore: cleanup — remove HeadSeo from migrated app router components Jan 10, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) January 10, 2025 07:19
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj merged commit 0a08680 into main Jan 10, 2025
43 of 83 checks passed
@hbjORbj hbjORbj deleted the chore/remove-headseo-from-app-router-components branch January 10, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee eunjae-lee approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @eunjae-lee @keithwillcode