Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve routing insights view (2) #18566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: improve routing insights view (2) #18566

wants to merge 1 commit into from
+72 −0

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 9, 2025 •
edited
Loading

What does this PR do?

This is a follow-up of #18557. It removes assignment_reasons_agg and moves it into a subquery.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

diff of the two migrations:

Screenshot 2025-01-09 at 18 01 27
Screenshot 2025-01-09 at 18 01 38
Screenshot 2025-01-09 at 18 01 53

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@linear Linear
Copy link

linear bot commented Jan 9, 2025

CAL-4995 Insights routing - performance issue

@github-actions github-actions bot added the ❗️ migrations contains migration files label Jan 9, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 9, 2025
@eunjae-lee eunjae-lee changed the title Eunjae/cal 4995 insights routing performance issue perf: improve routing insights view (2) Jan 9, 2025
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-4995-insights-routing-performance-issue branch from 89869ea to 7979899 Compare January 9, 2025 16:59
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 4:59pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 4:59pm

@calcom calcom deleted a comment from github-actions bot Jan 9, 2025
@eunjae-lee eunjae-lee marked this pull request as ready for review January 9, 2025 17:05
@graphite-app graphite-app bot requested a review from a team January 9, 2025 17:06
@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Jan 9, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 9, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/09/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ migrations contains migration files performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjae-lee @keithwillcode