chore: migrate 404 page to App Router #18449
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/03/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
force-pushed
the
chore/app-router-404-page
branch
from
58eb1dc to
4c892e7
Compare
| @@ -1,17 +0,0 @@ | |||
| "use client"; | |||
|
|
|||
| import { type NextPage } from "next"; | |||
There was a problem hiding this comment.
global-error is not needed. not-found is sufficient.
E2E results are ready! |
| "/signup", | ||
| "/settings/:path*", | ||
| "/reschedule/:path*", | ||
| "/availability/:path*", | ||
| "/booking/:path*", | ||
| "/payment/:path*", | ||
| "/router/:path*", | ||
| "/routing-forms/:path*", | ||
| "/org/:path*", | ||
| "/team/:path*", | ||
| "/:user/:type/", | ||
| "/:user/", |
There was a problem hiding this comment.
All routes must be included in the middleware config because the not-found page itself bypasses middleware processing. The not-found component depends on custom headers (like x-pathname and x-locale) that we set in middleware. Therefore, to ensure these headers are properly set before the not-found page is rendered, every route needs to go through middleware first.
|
Can we actually merge this now? Before we had issues where there were 404 page conflicts and it caused problems in the app. |
What does this PR do?
not-foundpage in App Router will display the custom error page (equivalent topages/404)pages/404Tested
Light Theme
Black Theme
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
http://localhost:3000/event-types/123/123,http://localhost:3000/12300, etc