Move RectorCakePHP rules here #197
Conversation
composer.json
Outdated
| @@ -6,11 +6,13 @@ | |||
| "license": "MIT", | |||
| "require": { | |||
| "cakephp/console": "^4.0", | |||
| "rector/rector": "^0.14.5" | |||
| "rector/rector": "dev-main", | |||
There was a problem hiding this comment.
@othercorey @markstory this can be updated to next rector relase
| @@ -6,11 +6,13 @@ | |||
| "license": "MIT", | |||
| "require": { | |||
| "cakephp/console": "^4.0", | |||
| "rector/rector": "^0.14.5" | |||
| "rector/rector": "dev-main", | |||
| "webmozart/assert": "^1.11" | |||
There was a problem hiding this comment.
this is needed as because the Webmozart\Assert\Assert that used in the rules are not scoped
…lude set lists already that include already
| @@ -6,11 +6,14 @@ | |||
| "license": "MIT", | |||
| "require": { | |||
| "cakephp/console": "^4.0", | |||
| "rector/rector": "^0.14.5" | |||
| "nette/utils": "^3.2", | |||
There was a problem hiding this comment.
this is needed as because the Nette\Utils\Strings that used in the rules are not scoped
| "rector/rector": "^0.14.5" | ||
| "nette/utils": "^3.2", | ||
| "rector/rector": "dev-main", | ||
| "symfony/string": "^6.0", |
There was a problem hiding this comment.
this is needed as use Symfony\Component\String\UnicodeString in ChangeSnakedFixtureNameToPascalRector rule.
|
@othercorey @markstory it should be ready now, feel free to take over :) |
| @@ -5,17 +5,23 @@ | |||
| "homepage": "http://cakephp.org", | |||
| "license": "MIT", | |||
| "require": { | |||
| "php": "^8.0", | |||
There was a problem hiding this comment.
The CI seems uses minimal php 8.0, so I added php requirement here.
There was a problem hiding this comment.
Hi @samsonasik I think it would be a problem for PHP7.4 users.
CakePHP 3.x has PHP requirement like this "php": ">=5.6.0,<8.0.0", Where as CakePHP 4.x "php": ">=7.4.0",
There was a problem hiding this comment.
This repo CI is using php 8.0 for minimal php version
upgrade/.github/workflows/ci.yml
Line 17 in 9823a2a
so I downgraded the rules to use php 8.0 syntax.
|
@othercorey @markstory Rector 0.14.6 released https://github.com/rectorphp/rector/releases/tag/0.14.6 . I think it is ready now, I updated the requirement to ^0.14.6 too for it d5952c0 |
|
Wow thank you for taking the time to do this @samsonasik 🙇 |
|
Looks good to me. Any concerns @othercorey @ADmad ? |
No. I'm sure we can work out any issues. |
None from me. |
|
Merging this into a separate branch. |
The RectorCakePHP is no longer exists in latest rector/rector:dev-main scoped vendor, so it moved the rules here.
Ref deprecated-packages/rector-cakephp#27