Fix environment.yml encoding and improve documentation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daklauss
reviewed
Dec 9, 2024
There was a problem hiding this comment.
That just means github doesn't attempt displaying it. The PR diff still says BIN but for the last commit cd8bed0 you'll see it treated as a text file. I could explicitly add it to .gitattributes but IMO that's not necessary.
There was a problem hiding this comment.
Should have been there earlier. Thanks
cbix
changed the title
|
@daklauss Is there something blocking this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the
environment.ymlis recognized as a binary file in git, which should be fixed by this patch.