Skip to content

Conversation

@daklauss
Copy link
Member

@daklauss daklauss commented Aug 11, 2025

This Draft updates to sundials 7.1.1 with vcpkg

TODOS/Problems to solve:

  • CMAKE/include/CICD files, sundials>=7 uses a generic sundials_core, that needs to be included for compilation
    • updatet cmake files necessary as well as different headers in code
    • ubuntu-latest only has sundials<=6.4.1 => own build within ci/cd pipeline necessary or using sundials<7
    • TimeIntegrator, SimulatorImpl, and gmres need to compile
  • ida_impl.h got removed with sundials>=4.1 => IDAMem not accessible anymore
    • IDA_mem->ida_lsolve = &linearSolveWrapper; not possible anymore, need sunlinearsolver "object" with own linear solver
    • IDASetMaxNonlinIters(_idaMemBlock, _maxNewtonIter); led to a crash
    • weights got removed from solve call of idas linsolver? setscalingvectors? couldnt find change history
  • suncontext "object" is needed to be created, handles sundials own error logs with sundials 6
  • Set sensmaxnonliniters after idasensinit point 20

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@daklauss
Copy link
Member Author

  • The CADET maintainers know my real name.

At least one of the following two applies:

  • The CADET maintainers know my current employer.

  • I am not making this contribution on behalf of my current employer.

@daklauss
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA.

@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 4 times, most recently from ead18d0 to 953dbfc Compare August 19, 2025 11:10
@cadet cadet deleted a comment from daklauss Aug 19, 2025
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 3 times, most recently from 3f973d5 to bccc591 Compare August 26, 2025 09:12
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from bccc591 to 980ef48 Compare October 7, 2025 09:23
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 6 times, most recently from 843f734 to bd9c003 Compare October 22, 2025 12:55
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 2 times, most recently from 8586a25 to 95f8267 Compare November 4, 2025 10:28
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 2 times, most recently from 6920cf0 to 57f2333 Compare November 18, 2025 12:05
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch 6 times, most recently from 0f36b96 to 85a9301 Compare November 19, 2025 14:59
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from 85a9301 to 38036a4 Compare November 19, 2025 15:00
@daklauss daklauss force-pushed the feature/update-sundials-7.1.1 branch from 38036a4 to 27943a3 Compare November 19, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants