-
Notifications
You must be signed in to change notification settings - Fork 37
Feature/update sundials 7.1.1 #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
daklauss
wants to merge
21
commits into
master
Choose a base branch
from
feature/update-sundials-7.1.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
9c0bb18 to
2cf9307
Compare
Member
Author
At least one of the following two applies:
|
Member
Author
|
I have read the CLA Document and I hereby sign the CLA. |
ead18d0 to
953dbfc
Compare
3f973d5 to
bccc591
Compare
bccc591 to
980ef48
Compare
843f734 to
bd9c003
Compare
8586a25 to
95f8267
Compare
6920cf0 to
57f2333
Compare
0f36b96 to
85a9301
Compare
85a9301 to
38036a4
Compare
38036a4 to
27943a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft updates to sundials 7.1.1 with vcpkg
TODOS/Problems to solve:
sundials_core, that needs to be included for compilationubuntu-latestonly has sundials<=6.4.1 => own build within ci/cd pipeline necessary or using sundials<7TimeIntegrator,SimulatorImpl, andgmresneed to compileida_impl.hgot removed with sundials>=4.1 =>IDAMemnot accessible anymoreIDA_mem->ida_lsolve = &linearSolveWrapper;not possible anymore, need sunlinearsolver "object" with own linear solverIDASetMaxNonlinIters(_idaMemBlock, _maxNewtonIter);led to a crashN_VectorinstancesSUNContext_PushErrHandlerinstead ofIDASetErrHandlerFnsundials 7 (Error Handling Changes)