ci(example-failure) Post on PRs when conventional commit format isn't used #7284
+55
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-warren
changed the title
|
This is waiting until we're able to update the actions settings to allow workflows to edit PRs (required to add a comment to a PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixes the semantic-pr workflow to post on the PR when the linter fails with helpful tips about writing PR titles.
Why?
The workflow was correctly failing (and correctly not preventing the PR from getting merged). However it was not immediately clear why the workflow was failing and the message within the workflow was obtuse.
How did you test it?
I did a lot of testing in https://github.com/c-warren/cdnc-release-please-test/pulls.
Potential risks
None
Release notes
N/A
Documentation Changes
None yet!