internal/tools: update revive version #7273
Open
+62
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: quantpoet <[email protected]>
quantpoet
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
dkrotx
requested changes
Sep 24, 2025
Comment on lines
+260
to
+261
| golang.org/x/tools/go/expect v0.1.1-deprecated // indirect | ||
| golang.org/x/tools/go/packages/packagestest v0.1.1-deprecated // indirect |
There was a problem hiding this comment.
We should avoid this. We recently had to rollback a similar change because of this update.
There was a problem hiding this comment.
It seems that this is indeed caused by the latest version of revive. However, I don’t have any ideas.
Do you have any suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The version of revive is too low and needs to be upgraded
For #7260
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes