Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cargo/runtime dependencies #396

Merged
merged 1 commit into from
Dec 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions modules/hooks.nix
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,18 @@ in

# PLEASE keep this sorted alphabetically.
options.settings = {
rust.cargoManifestPath = mkOption {
type = types.nullOr types.str;
description = "Path to Cargo.toml";
default = null;
rust = {
check.cargoDeps = mkOption {
type = types.nullOr types.attrs;
description = "Cargo dependencies needed to run the checks.";
example = "pkgs.rustPlatform.importCargoLock { lockFile = ./Cargo.lock; }";
default = null;
};
cargoManifestPath = mkOption {
type = types.nullOr types.str;
description = "Path to Cargo.toml";
default = null;
};
};
};

Expand Down
62 changes: 34 additions & 28 deletions modules/pre-commit.nix
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ let
;

inherit (pkgs) runCommand;
inherit (pkgs.rustPlatform) cargoSetupHook;
inherit (pkgs.stdenv) mkDerivation;

cfg = config;
install_stages = lib.unique (builtins.concatLists (lib.mapAttrsToList (_: h: h.stages) enabledHooks));
Expand All @@ -26,6 +28,7 @@ let
if excludes == [ ] then "^$" else "(${concatStringsSep "|" excludes})";

enabledHooks = filterAttrs (id: value: value.enable) cfg.hooks;
enabledExtraPackages = builtins.concatLists (mapAttrsToList (_: value: value.extraPackages) enabledHooks);
processedHooks =
mapAttrsToList (id: value: value.raw // { inherit id; }) enabledHooks;

Expand All @@ -51,34 +54,37 @@ let
);

run =
runCommand "pre-commit-run" { buildInputs = [ cfg.gitPackage ]; } ''
set +e
HOME=$PWD
# Use `chmod +w` instead of `cp --no-preserve=mode` to be able to write and to
# preserve the executable bit at the same time
cp -R ${cfg.rootSrc} src
chmod -R +w src
ln -fs ${configFile} src/.pre-commit-config.yaml
cd src
rm -rf .git
git init -q
git add .
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
git commit -m "init" -q
if [[ ${toString (compare install_stages [ "manual" ])} -eq 0 ]]
then
echo "Running: $ pre-commit run --hook-stage manual --all-files"
${cfg.package}/bin/pre-commit run --hook-stage manual --all-files
else
echo "Running: $ pre-commit run --all-files"
${cfg.package}/bin/pre-commit run --all-files
fi
exitcode=$?
git --no-pager diff --color
mkdir $out
[ $? -eq 0 ] && exit $exitcode
'';
mkDerivation {
name = "pre-commit-run";

src = cfg.rootSrc;
buildInputs = [ cfg.gitPackage ];
nativeBuildInputs = enabledExtraPackages
++ lib.optional (config.settings.rust.check.cargoDeps != null) cargoSetupHook;
cargoDeps = config.settings.rust.check.cargoDeps;
buildPhase = ''
set +e
HOME=$PWD
ln -fs ${configFile} .pre-commit-config.yaml
git init -q
git add .
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
git commit -m "init" -q
if [[ ${toString (compare install_stages [ "manual" ])} -eq 0 ]]
then
echo "Running: $ pre-commit run --hook-stage manual --all-files"
${cfg.package}/bin/pre-commit run --hook-stage manual --all-files
else
echo "Running: $ pre-commit run --all-files"
${cfg.package}/bin/pre-commit run --all-files
fi
exitcode=$?
git --no-pager diff --color
mkdir $out
[ $? -eq 0 ] && exit $exitcode
'';
};

failedAssertions = builtins.map (x: x.message) (builtins.filter (x: !x.assertion) config.assertions);

Expand Down
Loading