Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize #includes #804

Merged
merged 3 commits into from
Dec 23, 2023
Merged

reorganize #includes #804

merged 3 commits into from
Dec 23, 2023

Conversation

yaito3014
Copy link
Contributor

reorganizing #includes using IWYU except for headers within Rustify.hpp

  • Note
    • ::tolower and ::toupper are not guaranteed to be declared in <cctype> header, so there are two options:

      • option1: include <ctype.h> instead
      • option2: rewite those to like [](auto c) { return std::toupper(c); }

      This PR took option1 because the purpose of this is just organizing #includes.

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ken-matsui ken-matsui merged commit d7aa7c3 into cabinpkg:main Dec 23, 2023
14 checks passed
@yaito3014 yaito3014 deleted the fix-include branch December 26, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants