Cmd: add subcommand remove
#1125
Merged
+112
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR relies on functionality added in toml11 commit fdd5e29. I’ve left the PR in draft mode since updating the dependency is a significant change, and I wasn’t sure if it would be best handled here or separately. Please let me know if you'd like me to include the dependency update in this PR! |
|
@SunPodder Thanks for the PR! Feel free to update the toml11 version to the revision explicitly in this PR. I think you need modifications to cabin.toml and Makefile. |
|
Can you add integration tests in tests/? |
ken-matsui
reviewed
Jan 28, 2025
ken-matsui
reviewed
Jan 29, 2025
SunPodder
force-pushed
the
remove
branch
4 times, most recently
from
d29ec0a to
6a148f1
Compare
Remove project dependencies from cabin.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove project dependencies from cabin.toml
closes #1074