Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that twice poac build will be succeeded even if code is corrupted #1051

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue that twice poac build will be succeeded even if code is corrupted #1051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BuildConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,7 @@ emitMakefile(const bool isDebug, const bool includeDevDeps) {
// When emitting Makefile, we also build the project. So, we need to
// make sure the dependencies are installed.
config.installDeps(includeDevDeps);
config.configureBuild();

const std::string makefilePath = config.outBasePath / "Makefile";
if (isUpToDate(makefilePath)) {
Expand All @@ -959,7 +960,6 @@ emitMakefile(const bool isDebug, const bool includeDevDeps) {
}
logger::debug("Makefile is NOT up to date");

config.configureBuild();
std::ofstream ofs(makefilePath);
config.emitMakefile(ofs);
return config;
Expand Down
Loading