Skip to content

Ntrnl 555 make naming consistent in GitHub requests #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DanielMurray97
Copy link
Contributor

@DanielMurray97 DanielMurray97 commented Aug 20, 2024

JIRA link

Resolves NTRNL-555

Description

Fix naming inconsistencies related to collaborator validation, view, and model files.

Work checklist

  • Tests added where applicable
  • No vulnerability added

@DanielMurray97 DanielMurray97 self-assigned this Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 897/897
🟢 Branches 97.44% 38/39
🟢 Functions 100% 71/71
🟢 Lines 100% 831/831

Test suite run success

186 tests passing in 52 suites.

Report generated by 🧪jest coverage report action from c386609

Copy link
Contributor

@Mo-DBT Mo-DBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥 , tested locally all good, approved with a very small change to be done 🙏

@DanielMurray97 DanielMurray97 merged commit 1797b27 into main Aug 21, 2024
6 checks passed
@DanielMurray97 DanielMurray97 deleted the NTRNL-555-make-naming-consistent-in-github-requests branch August 21, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants