-
Notifications
You must be signed in to change notification settings - Fork 2
[18.0][IMP] sale_order_archive: add tutorial tour #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
192468e
to
2d5956c
Compare
2d5956c
to
a74b5e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich habe ein paar Verbesserungsvorschläge für den content gemacht. Mir geht es nicht in erster Regel darum, dass du sie 1:1 übernimmst, sondern es auch als Anregung für die nächsten tours. Nicht nur das "was" (klick) sondern vorallem das warum erklären. Das man beim Ballon klicken soll, ist glaube ich schon recht verständlich.
steps: () => [ | ||
stepUtils.showAppsMenuItem(), | ||
{ | ||
content: "Open the database", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vielleicht eher folgender text?
"Go to the sales app"
run: "click", | ||
}, | ||
{ | ||
content: "Choose the row with 'Quotation'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wir sollten hier erklären warum:
"Only canceled Quotations can be archived. Select a 'Quotation' to cancel"
{ | ||
content: "Go to 'Action'", | ||
trigger: "div:nth-child(2) > .o-dropdown", | ||
run: "click", | ||
}, | ||
{ | ||
content: "Choose 'Cancel'", | ||
trigger: ".o-dropdown-item:contains('Cancel')", | ||
run: "click", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich nicht jeder Baloon braucht eine Erklärung. Für die bessere Lesbarkeit zwei Schritte in einem erklären?
"Go to 'Action' and select 'Cancel'"
run: "click", | ||
}, | ||
{ | ||
content: "Confirm the cancellation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selbsterklärend?
trigger: ".o_technical_modal button[name='action_mass_cancel']", | ||
}, | ||
{ | ||
content: "Choose the row with 'Cancelled'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Choose the row which we have just 'Cancelled'"
run: "click", | ||
}, | ||
{ | ||
content: "Choose 'Archive'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hier sollten wir hervorheben, dass es der zu testende Schritt ist. Vielleicht etwas wie:
"Now we can test the 'Archive' action, added by the sale_order_archive module."
trigger: ".modal-footer .btn-primary", | ||
run: "click", | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vielleicht können wir noch zwei Schritte hinzufügen.
- Die liste nach archived filtern: "You can view all achived items by applying the achrive filter"
- Unarchive: Die Sale order wieder herstellen.
- Select the line
- action -> unarchive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Können wir die Datei und Tour noch in "sale_order_archive_tutorial.esm.js" umbennen?
No description provided.