Skip to content

[18.0][IMP] sale_order_archive: add tutorial tour #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 18.0
Choose a base branch
from

Conversation

leawolfgk
Copy link

No description provided.

@leawolfgk leawolfgk force-pushed the 18.0-imp-sale_order_archive-tour branch from 192468e to 2d5956c Compare March 21, 2025 11:16
@leawolfgk leawolfgk force-pushed the 18.0-imp-sale_order_archive-tour branch from 2d5956c to a74b5e3 Compare March 21, 2025 11:37
Copy link
Collaborator

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe ein paar Verbesserungsvorschläge für den content gemacht. Mir geht es nicht in erster Regel darum, dass du sie 1:1 übernimmst, sondern es auch als Anregung für die nächsten tours. Nicht nur das "was" (klick) sondern vorallem das warum erklären. Das man beim Ballon klicken soll, ist glaube ich schon recht verständlich.

steps: () => [
stepUtils.showAppsMenuItem(),
{
content: "Open the database",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht eher folgender text?
"Go to the sales app"

run: "click",
},
{
content: "Choose the row with 'Quotation'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wir sollten hier erklären warum:

"Only canceled Quotations can be archived. Select a 'Quotation' to cancel"

Comment on lines 25 to 34
{
content: "Go to 'Action'",
trigger: "div:nth-child(2) > .o-dropdown",
run: "click",
},
{
content: "Choose 'Cancel'",
trigger: ".o-dropdown-item:contains('Cancel')",
run: "click",
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich nicht jeder Baloon braucht eine Erklärung. Für die bessere Lesbarkeit zwei Schritte in einem erklären?

"Go to 'Action' and select 'Cancel'"

run: "click",
},
{
content: "Confirm the cancellation",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selbsterklärend?

trigger: ".o_technical_modal button[name='action_mass_cancel']",
},
{
content: "Choose the row with 'Cancelled'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Choose the row which we have just 'Cancelled'"

run: "click",
},
{
content: "Choose 'Archive'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier sollten wir hervorheben, dass es der zu testende Schritt ist. Vielleicht etwas wie:

"Now we can test the 'Archive' action, added by the sale_order_archive module."

trigger: ".modal-footer .btn-primary",
run: "click",
},
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht können wir noch zwei Schritte hinzufügen.

  • Die liste nach archived filtern: "You can view all achived items by applying the achrive filter"
  • Unarchive: Die Sale order wieder herstellen.
    • Select the line
    • action -> unarchive

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Können wir die Datei und Tour noch in "sale_order_archive_tutorial.esm.js" umbennen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants