Skip to content

Conversation

@any1here
Copy link

@any1here any1here commented Nov 8, 2025

No description provided.

@tonis2
Copy link
Contributor

tonis2 commented Nov 9, 2025

@any1here Isn't the sq_magnitude function already doing same thing ?

https://github.com/c3lang/c3c/blob/master/lib/std/math/vector.c3#L6-L7

@lerno
Copy link
Collaborator

lerno commented Nov 11, 2025

Yes there are those functions that already exist. So maybe we could close this? For future PRs, note that methods also use snake case style, so that the method would have to be length_sqr.

@any1here
Copy link
Author

Yes there are those functions that already exist. So maybe we could close this? For future PRs, note that methods also use snake case style, so that the method would have to be length_sqr.

Is there a reason why the length method is in math.c3 and sq_magnitude in vector.c3?
Also, the naming is confusing since one uses length while the other uses magnitude.

@any1here any1here closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants