Added "implement-libc" feature. #2564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds an option from project.json and build options to disable libc unreachable statements in order to be able to implement one for yourself. Useful feature for bare metal developing.
lerno
reviewed
Nov 10, 2025
| macro CFile stderr() { return (CFile*)(uptr)STDERR_FD; } | ||
|
|
||
| module libc @if(!env::LIBC); | ||
| module libc @if(!env::LIBC && !env::IMPLEMENT_LIBC); |
Collaborator
There was a problem hiding this comment.
Rather than doing this, let's change this to env::NO_LIBC and then only set env::NO_LIBC is neither exists. Also look at the ones doing @if(env::LIBC) to see if they should be included when LIBC is implemented by the custom libc
Author
There was a problem hiding this comment.
NO_LIBC is set by "link-libc", so are you suggesting to use that mechanism?
Contributor
There was a problem hiding this comment.
I think he means changing the definition of NO_LIBC to something like const bool NO_LIBC = !LIBC && !CUSTOM_LIBC
Collaborator
|
Rename |
Collaborator
|
Ping! |
Author
I'm dealing with a heavy flu right now xD sorry for the delay, i'm unable to do anything atm |
Collaborator
|
It's fine, I hope you get well soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds an option from project.json and build options to disable libc unreachable statements in order to be able to implement one for yourself. Useful feature for bare metal developing.