Add test option --test-log-level to choose tests' log level
#2560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0tholith
force-pushed
the
add_test_log_level_option
branch
from
01d2aa7 to
b9822e5
Compare
Contributor
Author
|
Made argument passed to |
Contributor
Author
|
(bump @lerno) |
lerno
reviewed
Nov 10, 2025
src/build/build_options.c
Outdated
| options->test_filter = next_arg(); | ||
| return; | ||
| } | ||
| if (match_longopt("test-log-level")) |
Collaborator
There was a problem hiding this comment.
Better use match_argopt with the different options here.
Collaborator
There was a problem hiding this comment.
You can see from the other examples how it works.
lerno
reviewed
Nov 10, 2025
lib/std/core/runtime_test.c3
Outdated
| io::printn("Missing log level for argument `--test-log-level`."); | ||
| return false; | ||
| } | ||
| args[i + 1].convert_to_lower(); |
Collaborator
There was a problem hiding this comment.
If you convert it to upper case instead, you can use enum_by_name(LogPriority, args[i + 1]) and drop the switch.
lerno
reviewed
Nov 10, 2025
lib/std/core/runtime_test.c3
Outdated
| case "critical": context.log_level = LogPriority.CRITICAL; | ||
| default: | ||
| io::print("Log level given to `--test-log-level` is not one of: "); | ||
| $foreach $level : LogPriority.names[:^1]: |
Collaborator
There was a problem hiding this comment.
Since LogPriority will not change, just write this as a hard coded description rather than grabbing the names.
Collaborator
|
I'll look at this on Friday. Remind me if I forget. |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.