Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doc Tests Compilation #99

Closed
wants to merge 1 commit into from
Closed

Fix Doc Tests Compilation #99

wants to merge 1 commit into from

Conversation

Borwe
Copy link
Contributor

@Borwe Borwe commented Jan 26, 2024

Basically replaced:

env!("CLIENT_KEY")
env!("CLIENT_SECRET") 

with

std::env::var("CLIENT_KEY").unwrap(),
std::env::var("CLIENT_SECRET").unwrap(),

since the env variables aren't available at compile time we can't use env! directly.

Fixes #97

@Borwe
Copy link
Contributor Author

Borwe commented Jan 26, 2024

Hmm... Still failing, this is interesting lol.

@Borwe Borwe marked this pull request as draft January 26, 2024 16:53
@c12i
Copy link
Owner

c12i commented Jan 26, 2024

@Borwe thanks for checking this out

the strange thing was that even with env! the tests passed before, my guess is that either the API are down or there are breaking changes that need to be accounted for

@c12i
Copy link
Owner

c12i commented Jan 26, 2024

will have a closer look at this over the weekend

@itsyaasir
Copy link
Collaborator

This issue has been fixed, all the tests are passing.

@itsyaasir itsyaasir marked this pull request as ready for review January 29, 2024 03:12
@itsyaasir
Copy link
Collaborator

This issue has been fixed, Thanks @Borwe

@itsyaasir itsyaasir closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate failing doc tests for potential breaking API changes
3 participants