chore: move express-request and transaction reversal to builder pattern #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12i
requested changes
Nov 21, 2023
receiver identifier type
c12i
reviewed
Nov 22, 2023
c12i
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Added some comments on the amount field for the request and builder structs, as a simple workaround, we should consider switching to u32 to avoid potential validation errors. This would mean removing the #[builder(setter(into))] attribute on the amount field for the builder structs
The only floating point number accepted by Safaricom is <num>.0, so to avoid these kinds of errors, let's always send whole numbers to Safaricom
I noticed this was a problem while working on #90
express_request.rs and transaction_reversal.rs
c12i
approved these changes
Nov 29, 2023
|
Hey @itsyaasir, I'm looking into the why the CI workflow is failing |
|
I think |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Closes #43
Closes #24