Skip to content

Commit

Permalink
update contributing
Browse files Browse the repository at this point in the history
  • Loading branch information
devarshishimpi committed Oct 10, 2022
1 parent d2e4772 commit eb72097
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- [ ] I have performed a self-review of my code.

- [ ] Followed the repository's [Contributing Guidelines](/CONTRIBUTING.md).
- [ ] Followed the repository's [Contributing Guidelines](https://github.com/dvstechlabs/Noteslify/blob/main/CONTRIBUTING.md).

- [ ] I ran the app and tested it locally to verify that it works as expected.

Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ Please note we have a [Code of Conduct](CODE_OF_CONDUCT.md), please follow it in
1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
2. Update `README.md` with details of changes to the interface: this includes new environment variables, exposed ports, useful file locations and container parameters.
3. Increase the version numbers in any examples files and the `README.md` to the new version that this PR would represent.
4. You may merge the PR once you have the sign-off of two other developers, or if you do not have permission to do that, you may request the second reviewer merge it for you.
4. Ensure that you have made an issue or have been assigned to the issue you were creating PR for.
5. You may merge the PR once you have gained approval, or you may request approval from the maintainers who have write access to the repository.

0 comments on commit eb72097

Please sign in to comment.