-
Notifications
You must be signed in to change notification settings - Fork 257
feat(go): creating remote package for reusable bindings #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b8feb32 to
a2f25bf
Compare
dicej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! LGTM overall; just a few comments inline.
ffc1ee4 to
b543a78
Compare
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
|
@asteurer When I run the tests locally and then run diff --git a/wit_component/go.mod b/wit_component/go.mod
index 1376492c..dd0a084c 100644
--- a/wit_component/go.mod
+++ b/wit_component/go.mod
@@ -2,4 +2,4 @@ module wit_component
go 1.25
-replace github.com/bytecodealliance/wit-bindgen => /home/asteurer/repos/wit-bindgen/crates/go/src/package
+replace github.com/bytecodealliance/wit-bindgen => /home/dicej/p/wit-bindgen/crates/go/src/packageIs there a way we could avoid putting local paths in a file tracked by Git? |
|
@dicej 🤦 That's an artifact from the runtime test that snuck in. I'll remove that real quick |
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
|
@alexcrichton any concerns about the new CI step (or any other aspect of this PR)? |
alexcrichton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Overview
This closes #1484
Usage
Since the Go package hasn't yet been set up, you can try the new functionality by replacing the following line in the generated
wit_componentgo.mod file:@dicej