This repository was archived by the owner on Jun 16, 2020. It is now read-only.
Remove special casing for old spec test error messages #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
commented
Feb 19, 2020
There was a problem hiding this comment.
Wait the fix hasn't been merged into https://github.com/WebAssembly/testsuite/ yet so I'm not sure why this is passing...
yurydelendik
force-pushed
the
remove-special-casing-of-errors
branch
from
ea00989 to
45e2130
Compare
|
I rebased the patch. I'm getting locally (and during checks): |
|
(as a heads up this repo is moved to https://github.com/bytecodealliance/wasm-tools now) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passive elements used to have a bad expected error message in the spec tests but that's since been fixed.