-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uninit buffer ancillary APIs #1108
Add uninit buffer ancillary APIs #1108
Conversation
Nevermind, I don't think backcompat is possible without implementing a trait for both |
Staging needs a rebase and also #1107 |
619d4fd
to
70b188a
Compare
Annnnnd I decided to make it backwards compatible again. The public API should be identical except there's now a |
Not sure why the tests are so borked. |
70b188a
to
34c1c87
Compare
34c1c87
to
bbd9095
Compare
Ok so the idea with this one is that the |
Signed-off-by: Alex Saveau <[email protected]>
bbd9095
to
283e09c
Compare
I've now rebased this and fixed the merge conflicts. |
Can we remove the non MaybeUninit versions? I personally don't think you should be using u8s for these buffers since we take care of giving you a nice well typed iterator. |
Yep, I was just reading your comment above about that too. |
Brilliant, this looks great! |
Thanks! |
Pretty sure I managed to maintain backcompat via a conversion trait.
Closes #1103