Skip to content

fix: treat synckit as an optional dependency #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

guybedford
Copy link
Collaborator

This treats synckit used in the Node.js http shim as an optional dependency.

@eduardomourar ideally I think we should fully inline any dependency usage if we can, as it would be great to have no dependencies for this.

@guybedford guybedford merged commit 8b791a5 into main Feb 20, 2023
@guybedford guybedford deleted the synckit-optional branch February 20, 2023 17:16
@eduardomourar
Copy link
Contributor

fully agree on this

@eduardomourar
Copy link
Contributor

i guess we should include synckit to the optionalDependencies within package.json, right?

@guybedford
Copy link
Collaborator Author

Unfortunately optionalDependencies in Node.js don't really work since they are only based on "engines" field filtering, as opposed to actual usage.

Usually I'd just prefer to use devDependencies and bundle any dependencies in with a build. It depends on the footprint though. Synckit doesn't seem too bad (https://bundlephobia.com/package/[email protected]).

@eduardomourar
Copy link
Contributor

The underlying problem that I tried to solve is this one here: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants