Expand WIT overview section #288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Comment on lines
+3
to
+4
| We've explained how worlds and interfaces | ||
| define how components relate to each other. |
There was a problem hiding this comment.
Probably can remove this -- someone may land on this page without going to the other ones, I think.
If we want to refer to the previous section, then we maybe could include a link and a statement that is more general/doesn't expect the transition from the previous page.
Comment on lines
+10
to
+12
| The WIT (Wasm Interface Type) language is used to define Component Model [interfaces](#interfaces) and [worlds](#worlds). | ||
| WIT isn't a general-purpose programming language and doesn't define behaviour; | ||
| it defines only _contracts_ between components. |
There was a problem hiding this comment.
These two lines feel like they should be the first ones
| They can pass ownership of resources, or pass non-owned references to resources. | ||
|
|
||
| > If you're not familiar with the concepts of borrowing and ownership | ||
| > for pointers, see [the Rust documentation](https://doc.rust-lang.org/book/ch04-01-what-is-ownership.html). |
There was a problem hiding this comment.
Suggested change
| > for pointers, see [the Rust documentation](https://doc.rust-lang.org/book/ch04-01-what-is-ownership.html). | |
| > for references, see [the Rust documentation](https://doc.rust-lang.org/book/ch04-01-what-is-ownership.html). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes here are to add semantic line breaks, but I did expand on some concepts, particularly resources.