dir: Add try_exists()
#234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Feb 8, 2022
There was a problem hiding this comment.
cap-std usually puts features corresponding to unstable features in std behind a config option, however in this case, I think it's reasonable to just provide these. As you say, it's unlikely that these will change before stabilization, and they're useful.
Please add comments to the cap-std versions mentioning that the std version is not yet stabilized though, with a link to the tracking issue. And please add comments to the cap-async-std versions mentioning that cap-async-std doesn't have these operations yet.
I want to use this for the same reason as rust-lang/rust#81822 was added to std. While it's currently unstable, I can't imagine it would change.
cgwalters
force-pushed
the
try-exists
branch
from
ce73c9b to
913116d
Compare
|
OK, comments should be addressed! |
sunfishcode
approved these changes
Feb 11, 2022
|
This is now released in 0.24.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use this for the same reason as
rust-lang/rust#81822
was added to std. While it's currently unstable, I can't imagine
it would change.