Persist default values for Rails 6.1 #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
force-pushed
the
persisted-defaults-test-coverage
branch
from
e9baa15 to
51402b6
Compare
This extends the fix from 1f150f6 to Rails 6.1, and adds test coverage. Specifically, it adds a record reload to the "stores the default on creation" test to ensure that the postcondition holds. Without the reload, the "stores the default on creation" test would pass even before 1f150f6. This commit also adds a test for when the record is partially loaded, and changes some Rails private API calls to equivalent public API calls.
jonathanhefner
force-pushed
the
persisted-defaults-test-coverage
branch
from
51402b6 to
89dc6aa
Compare
jonathanhefner
changed the title
|
Based on the previous test failure, I pushed a commit to extend the fix from #95 to Rails 6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the fix from 1f150f6 to Rails 6.1, and adds test coverage. Specifically, it adds a record reload to the "stores the default on creation" test to ensure that the postcondition holds. Without the reload, the "stores the default on creation" test would pass even before 1f150f6.
This commit also adds a test for when the record is partially loaded, and changes some Rails private API calls to equivalent public API calls.
Extracted from #96.