Mutable #320
Merged
Mutable #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giann
force-pushed
the
mutable
branch
4 times, most recently
from
70dfbcb to
4c17106
Compare
When JIT code calls a function, it allocate a slot on the stack to hold its NativeCtx. That alloca was outliving the function being called since it was allocated outside of it. tests/bench/008-for.buzz was crashing because we were doing 1M function call in the same function and so stacking 1M alloca. => We put the alloca inside a BSTART/BEND so the alloca is released once the function is being called is done
giann
force-pushed
the
mutable
branch
5 times, most recently
from
de0b495 to
06a3194
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.